Re: [Qemu-devel] [PATCH v1] exec: handle NULL pointer in flatview_read_continue

[Olaf Hering]

Am Fri, 10 Aug 2018 14:29:28 +0200
schrieb Paolo Bonzini <address@hidden>:

> On 10/08/2018 12:32, Olaf Hering wrote:
> > Am Fri, 10 Aug 2018 12:25:09 +0200
> > schrieb Paolo Bonzini <address@hidden>:
> > So you mean that function must not return NULL?
> > Or should the caller check for the result?  
> Either, but the former would of course be much simpler if possible.

Since other callers already deal with NULL, that one has to cope as well.
And since unavailable memory can not be zero, the memset 0xff is most likely 
correct as well.

So, for me the patch is good as it is. The write part will get a separate 
change in a few days.


Olaf

pgpYwFzJiC_2F.pgp
Description: Digitale Signatur von OpenPGP