[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'inf

From: Emilio G. Cota
Subject: Re: [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'info sync'
Date: Tue, 14 Aug 2018 21:33:47 -0400
User-agent: Mutt/1.9.4 (2018-02-28)

On Tue, Aug 14, 2018 at 10:43:47 +0100, Dr. David Alan Gilbert wrote:
> * Emilio G. Cota (address@hidden) wrote:
> > address@hidden info sync
> As long as this is just for devs I'm OK with this from the HMP side;
> however, if you want to automate the display or wire it to other
> tools then you should probably wire it up via QMP.

On Tue, Aug 14, 2018 at 18:03:32 +0200, Markus Armbruster wrote:
> "Emilio G. Cota" <address@hidden> writes:
> > address@hidden info sync
> Please explain briefly why you think this command is not going to be
> useful in QMP.  Recommend to do that right in your commit message.  For
> instance, you could argue that the information provided is useful only
> to developers, and developers are just fine with getting it from HMP
> "info sync".
> However, if we expect developers to further process the data, providing
> it as JSON (via QMP) makes sense, because is saves them the trouble of
> parsing your (undocumented) HMP output format.
> If we decide we want to provide the functionality in QMP, I can help you
> with the necessary code changes.

Thanks Dave and Markus for taking a look.

This is just for developers. This means (1) the info displayed and the
output format could change in the future, and (2) it is only meant
to be used from HMP "info sync-profile".

I'll include the above in the commit log, as Markus suggested.

> > +        .name       = "sync",
> I think "info sync-profile" would be clearer.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]