[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] tests/device-introspection: Check that the
Re: [Qemu-devel] [PATCH 2/6] tests/device-introspection: Check that the qom-tree and qtree do not change
Wed, 15 Aug 2018 07:56:59 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
On 08/14/2018 07:53 PM, Markus Armbruster wrote:
> Thomas Huth <address@hidden> writes:
>> Introspection should not change the qom-tree / qtree, so we should check
>> this in the device-introspect-test, too. This patch helped to find lots
>> of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the
>> last two months.
> Clever idea.
>> Signed-off-by: Thomas Huth <address@hidden>
>> tests/device-introspect-test.c | 23 +++++++++++++++++++----
>> 1 file changed, 19 insertions(+), 4 deletions(-)
>> diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c
>> index 0b4f221..5b7ec05 100644
>> --- a/tests/device-introspect-test.c
>> +++ b/tests/device-introspect-test.c
>> @@ -103,7 +103,14 @@ static QList *device_type_list(bool abstract)
>> static void test_one_device(const char *type)
>> QDict *resp;
>> - char *help, *qom_tree;
>> + char *help;
>> + char *qom_tree_start, *qom_tree_end;
>> + char *qtree_start, *qtree_end;
>> + g_debug("Testing device '%s'", type);
> This is only the second use of g_debug() in tests/. What are you trying
> to accomplish?
When the test crashes, I need a way to determine the device which caused
the crash. To avoid that I've then got to insert fprintf statements
manually here and recompile, the g_debug() seems to be a good solution,
since you can enable its output by setting some environment variable (I
use G_MESSAGES_DEBUG=all and G_MESSAGES_PREFIXED=none).
Or do you see a better way to provide a possibility to determine the
device that caused a crash?
[Qemu-devel] [PATCH 3/6] hw/timer/mc146818rtc: White space clean-up, Thomas Huth, 2018/08/14
[Qemu-devel] [PATCH 4/6] hw/timer/mc146818rtc: Fix introspection problem, Thomas Huth, 2018/08/14
[Qemu-devel] [PATCH 5/6] net: Silence 'has no peer' messages in testing mode, Thomas Huth, 2018/08/14