[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command
Date: Wed, 15 Aug 2018 16:29:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Simon Ruderich <address@hidden> writes:

> On Wed, Aug 15, 2018 at 06:22:51AM +0200, Markus Armbruster wrote:
>>> My initial patch didn't have the offset. It was suggested by Eric
>>> Blake in <address@hidden>:
>>> On Tue, Apr 10, 2018 at 04:33:03PM -0500, Eric Blake wrote:
>>>> Do you additionally need an offset where to start reading from within
>>>> the file (that is, since you already have the 'size' parameter to avoid
>>>> reading the entire file, and the 'val' parameter to target anywhere in
>>>> physical memory, how do I start reading anywhere from the file)?
>>> It sounded useful to me so I added it.
>> Feels like an optional parameter to me.
> For the HMP or the QMP interface?


> If you think 'offset' is not necessary I can also drop it
> completely.

I think it's a reasonable feature, and since you already coded it up...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]