[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes un
Re: [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes until finalize
Wed, 15 Aug 2018 17:04:10 +0200
On Wed, Aug 15, 2018 at 17:00:29 +0200, Kevin Wolf wrote:
> Am 15.08.2018 um 16:44 hat Peter Krempa geschrieben:
> > On Tue, Aug 07, 2018 at 00:33:28 -0400, John Snow wrote:
> > > This series forces all jobs to use the "finalize" semantics that were
> > > introduced previously, but only exposed via the backup jobs.
> > > This series looks huge, but it's mostly mechanical changes broken out
> > > into a series of much smaller commits so that the changes are easier
> > > to follow at each step.
> > Please note that due to the semantics of the commands 'block-job-cancel'
> > and 'block-job-complete' at least in case of the drive/blockdev-mirror
> > job are technically blockjobs of it's own since they may fail or finish
> > in an unbounded amount of time and the actual return value on the
> > monitor does not reflect the result of the operation itself.
> > It would be very helpful if qemu treas them as such.
> 'block-job-cancel' and 'block-job-complete' return immediately. They
> just move the given job into the next phase and return. That job may
> then still take some time until it finally completes (successfully or
> with an error), but that's not part of 'block-job-cancel/complete' any
Ah I see. That means that we just need to modify the semantics/language
used in libvirt for this.
Thanks for the clarification.
Description: PGP signature
- [Qemu-devel] [PATCH 13/21] block/commit: add block job creation flags, (continued)
- [Qemu-devel] [PATCH 13/21] block/commit: add block job creation flags, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 05/21] block/mirror: utilize job_exit shim, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 17/21] block/mirror: conservative mirror_exit refactor, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 16/21] block/commit: refactor commit to use job callbacks, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 21/21] qapi/block-stream: expose new job properties, John Snow, 2018/08/07
- Re: [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes until finalize, Peter Krempa, 2018/08/15