[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

From: Simon Ruderich
Subject: Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command
Date: Wed, 15 Aug 2018 17:46:26 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

On Wed, Aug 15, 2018 at 04:29:25PM +0200, Markus Armbruster wrote:
>> For the HMP or the QMP interface?
> Both.


>> If you think 'offset' is not necessary I can also drop it
>> completely.
> I think it's a reasonable feature, and since you already coded it up...

In that case, should size also become optional? As already
suggested in this thread (and similar for QMP):

On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
> Also, had you considered rearranging and making them optional,
> for example if you do:
> val:l,filename:F,offset:i?,size:i?
> I think that would mean you can do the fairly obvious:
>   pmemload addr "myfile"
> with the assumption that loads the whole file.

This would deviate from pmemsave/memsave, but feels more natural.

How are multiple optional parameters handled? Filled from

+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]