[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 22/22] virtio: split virtio-serial bits rom v
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 22/22] virtio: split virtio-serial bits rom virtio-pci |
Date: |
Thu, 16 Aug 2018 09:24:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/08/2018 01:48 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> hw/virtio/Makefile.objs | 1 +
> hw/virtio/virtio-pci.c | 74 --------------------------
> hw/virtio/virtio-serial-pci.c | 97 +++++++++++++++++++++++++++++++++++
> tests/Makefile.include | 12 ++---
> 4 files changed, 104 insertions(+), 80 deletions(-)
> create mode 100644 hw/virtio/virtio-serial-pci.c
[...]
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index a1352ccefb..8666206ea4 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -143,7 +143,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF)
> ifneq (,$(findstring qemu-ga,$(TOOLS)))
> -check-unit-$(CONFIG_LINUX) += tests/test-qga$(EXESUF)
> +check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) +=
> tests/test-qga$(EXESUF)
Maybe mention qga's dependency in the patch description?
Anyway:
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH v2 16/22] virtio: split vhost-user-blk bits from virtio-pci, (continued)
- [Qemu-devel] [PATCH v2 18/22] virtio: split vhost-scsi bits from virtio-pci, Juan Quintela, 2018/08/08
- [Qemu-devel] [PATCH v2 17/22] virtio: split vhost-user-scsi bits from virtio-pci, Juan Quintela, 2018/08/08
- [Qemu-devel] [PATCH v2 19/22] virtio: split virtio-scsi bits from virtio-pci, Juan Quintela, 2018/08/08
- [Qemu-devel] [PATCH v2 20/22] virtio: split virtio-blk bits rom virtio-pci, Juan Quintela, 2018/08/08
- [Qemu-devel] [PATCH v2 22/22] virtio: split virtio-serial bits rom virtio-pci, Juan Quintela, 2018/08/08
- Re: [Qemu-devel] [PATCH v2 22/22] virtio: split virtio-serial bits rom virtio-pci,
Thomas Huth <=
- [Qemu-devel] [PATCH v2 21/22] virtio: split virtio-net bits rom virtio-pci, Juan Quintela, 2018/08/08
- Re: [Qemu-devel] [RFC PATCH v2 00/22] More patches to disable stuff, Paolo Bonzini, 2018/08/10