[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] arm: Move nRF51 machine state to dedicated
Re: [Qemu-devel] [PATCH 2/7] arm: Move nRF51 machine state to dedicated header
Thu, 16 Aug 2018 15:58:12 +0100
On 11 August 2018 at 10:08, Steffen Görtz <address@hidden> wrote:
> The machine state will be used to host the SOC
> and board level devices like the LED matrix and
> devices to handle to pushbuttons A and B.
> Signed-off-by: Steffen Görtz <address@hidden>
> hw/arm/microbit.c | 38 ++++++++++++++++++++++++--------------
> include/hw/arm/microbit.h | 29 +++++++++++++++++++++++++++++
> 2 files changed, 53 insertions(+), 14 deletions(-)
> create mode 100644 include/hw/arm/microbit.h
These changes should be squashed into Joel's initial
patch creating the machine, as per discussion on that patch.
I don't think we really need a separate header file,
unless there's something I'm missing because I haven't yet
read later patches in the series.