[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/8] i386: Disable TOPOEXT by default on "-cpu host"
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 8/8] i386: Disable TOPOEXT by default on "-cpu host" |
Date: |
Thu, 16 Aug 2018 22:34:00 -0300 |
Enabling TOPOEXT is always allowed, but it can't be enabled
blindly by "-cpu host" because it may make guests crash if the
rest of the cache topology information isn't provided or isn't
consistent.
This addresses the bug reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1613277
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Tested-by: Richard W.M. Jones <address@hidden>
Reviewed-by: Babu Moger <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
target/i386/cpu.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 52a77a7d08..4e4fe8fa8b 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -849,6 +849,12 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
},
.cpuid_eax = 0x80000001, .cpuid_reg = R_ECX,
.tcg_features = TCG_EXT3_FEATURES,
+ /*
+ * TOPOEXT is always allowed but can't be enabled blindly by
+ * "-cpu host", as it requires consistent cache topology info
+ * to be provided so it doesn't confuse guests.
+ */
+ .no_autoenable_flags = CPUID_EXT3_TOPOEXT,
},
[FEAT_C000_0001_EDX] = {
.feat_names = {
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-devel] [PULL 0/8] x86 queue, 2018-08-16, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 2/8] i386: Add new MSR indices for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 3/8] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 1/8] docs: add guidance on configuring CPU models for x86, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 4/8] i386: Add CPUID bit for PCONFIG, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 5/8] i386: Add CPUID bit for WBNOINVD, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 7/8] target-i386: adds PV_SEND_IPI CPUID feature bit, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 6/8] i386: Add new CPU model Icelake-{Server, Client}, Eduardo Habkost, 2018/08/16
- [Qemu-devel] [PULL 8/8] i386: Disable TOPOEXT by default on "-cpu host",
Eduardo Habkost <=
- Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-08-16, Peter Maydell, 2018/08/17
- Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-08-16, no-reply, 2018/08/17