[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support M
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features |
Date: |
Fri, 17 Aug 2018 12:55:24 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Fri, Aug 17, 2018 at 05:50:15PM +0200, Paolo Bonzini wrote:
> On 10/08/2018 16:06, Robert Hoo wrote:
> > +typedef enum FeatureWordType {
> > + CPUID_FEATURE_WORD,
> > + MSR_FEATURE_WORD,
> > +} FeatureWordType;
>
> This enum probably should be defined with QAPI, so that it can be reused
> in the feature-words property:
>
> # @X86CPUFeatureWordType:
> #
> # Kinds of X86 CPU feature words
> #
> # @cpuid: A CPUID leaf
> #
> # @msr: An MSR
> ##
> { 'enum': 'X86CPUFeatureWordType',
> 'data': 'cpuid', 'msr' }
>
> The names will be X86_CPU_FEATURE_WORD_TYPE_CPUID and
> X86_CPU_FEATURE_WORD_TYPE_MSR.
I wouldn't like to make this an external API unless really
necessary. I would rather deprecate the "feature-words" property
because nobody ended up using it.
--
Eduardo
- Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[], (continued)
Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[], Paolo Bonzini, 2018/08/17
[Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features, Robert Hoo, 2018/08/10
Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features, Paolo Bonzini, 2018/08/17
[Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Robert Hoo, 2018/08/10