[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

From: Dr. David Alan Gilbert
Subject: Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires
Date: Fri, 17 Aug 2018 17:09:34 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

* Paolo Bonzini (address@hidden) wrote:
> On 16/08/2018 09:22, Zhoujian (jay) wrote:
> > Could we add the check !runstate_check(RUN_STATE_FINISH_MIGRATE) before 
> > setting
> > to RUN_STATE_PRELAUNCH, just like !runstate_check(RUN_STATE_RUNNING) and
> > !runstate_check(RUN_STATE_INMIGRATE) did? But I'm not sure whether this will
> > cause any side effect.
> I think there is a bigger problem to fix before.  global_state_store
> sees RUNNING, not PRELAUNCH; the VM is migrated with state that is
> already reset, but the state on the destination is RUNNING and the VM
> restarts running on the destination.  Likewise, if migration fails the
> VM is resumed on the source because s->vm_was_running is true.
> David, Juan, do you have any ideas here?

Would it help if we didn't process the reset-request at all while the
guest was paused; so the guest state didn't get reset?
I think you'd have to then migrate the 'reset-requested' flag to cause
it to happen on the destination.


> Paolo
Dr. David Alan Gilbert / address@hidden / Manchester, UK

reply via email to

[Prev in Thread] Current Thread [Next in Thread]