[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/20] target/arm: Fix is_a64 for user-only
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 07/20] target/arm: Fix is_a64 for user-only |
Date: |
Fri, 17 Aug 2018 17:23:14 +0100 |
On 17 August 2018 at 17:10, Laurent Desnogues
<address@hidden> wrote:
> Hello,
>
> On Fri, Aug 17, 2018 at 6:04 PM Peter Maydell <address@hidden> wrote:
>> And again. I don't want to pepper the code with ifdefs if
>> we can do the right thing without them.
>
> FWIW I find it more readable with the ifdef's (here and in the
> previous patches) and I guess that helps the compiler too.
Hmm. I prefer to think of user-mode as a funny variant on
system emulation where we make the minimal changes required,
and mostly work just by having the CPU being in the state it
would be for system-emulation EL0 and not being able to get out
of it.
thanks
-- PMM