[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 25/60] json: Leave rejecting invalid escape s

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 25/60] json: Leave rejecting invalid escape sequences to parser
Date: Mon, 20 Aug 2018 10:44:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 08/17/2018 10:05 AM, Markus Armbruster wrote:
>> Both lexer and parser reject invalid escape sequences in strings.  The
>> parser's check is useless.
>> While there, fix parse_string()'s inaccurate function comment.
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> + * From RFC 7159 "The JavaScript Object Notation (JSON) Data
>> + * Interchange Format":
> You did point out in the cover letter that you intend to rewrite this
> to point to 8259. (That's saying something - when portions of these
> patches have been around on our mailing list prior to the point of the
> RFC being updated).

I spotted the "Obsoleted by: 8259" in RFC 7159 pretty much by chance
during development of this series, but neglected to work in the update
right away.

>                     Here, and elsewhere in the series, that's minor
> enough that I don't see it invalidating any of my R-b.
> Reviewed-by: Eric Blake <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]