[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/boot-serial-test: Bump timeout to 6 minut
Re: [Qemu-devel] [PATCH] tests/boot-serial-test: Bump timeout to 6 minutes
Mon, 20 Aug 2018 09:45:15 +0100
On 20 August 2018 at 07:21, Thomas Huth <address@hidden> wrote:
> On 2018-08-18 12:10, Peter Maydell wrote:
>> On 18 August 2018 at 10:07, Thomas Huth <address@hidden> wrote:
>>> 6 minutes is really a lot already. I guess most users will hit CTRL-C
>>> before waiting so long if there is a realy problem here ... If the
>>> current tests just takes a little bit more than 1 minute on the Sparc
>>> machine, maybe 2 or 3 minutes would sufficient, too?
>> Or maybe not. I don't like tests that run close to their timeout
>> limits, because that tends to mean that my automated test runs
>> are flaky when the machine happens to be heavily loaded when
>> a test is running. I think the purpose of a timeout is to prevent
>> the test run hanging indefinitely; as you say, console users can
>> hit ctrl-c if they get bored anyway.
> ... or maybe somebody tries to run TCI on a Sparc host one day ... ok,
> you've convinced me, let's go with the 360 seconds:
> Reviewed-by: Thomas Huth <address@hidden>
> Paolo, could you please queue up this patch (since I don't have anything
> else pending for assembling a PULL request)?
I can just apply it directly, since it's useful for buildtesting.