[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] tcg: Split CONFIG_ATOMIC128
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] tcg: Split CONFIG_ATOMIC128 |
Date: |
Mon, 20 Aug 2018 12:26:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/17/2018 09:42 AM, Emilio G. Cota wrote:
>> +/* Through gcc 8, aarch64 has no support for 128-bit at all. */
>> +static inline Int128 atomic16_cmpxchg(Int128 *ptr, Int128 cmp, Int128 new)
>> +{
>> + uint64_t cmpl = cmp, cmph = cmp >> 64;
>> + uint64_t newl = new, newh = new >> 64;
> Here I'd use int128_getlo/hi, since we're not checking for
> CONFIG_INT128 (I'm thinking of old compilers here)
I suppose, but this is aarch64 -- there are no really old compilers.
The oldest is probably gcc 4.8, which already has __int128_t.
Thanks for the other catches too.
r~
- [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations, Richard Henderson, 2018/08/15
- [Qemu-devel] [PATCH 2/5] target/i386: Convert to HAVE_CMPXCHG128, Richard Henderson, 2018/08/15
- [Qemu-devel] [PATCH 3/5] target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128, Richard Henderson, 2018/08/15
- [Qemu-devel] [PATCH 5/5] target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128, Richard Henderson, 2018/08/15
- [Qemu-devel] [PATCH 1/5] tcg: Split CONFIG_ATOMIC128, Richard Henderson, 2018/08/15
- [Qemu-devel] [PATCH 4/5] target/arm: Convert to HAVE_CMPXCHG128, Richard Henderson, 2018/08/15
- Re: [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations, no-reply, 2018/08/17
- Re: [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations, no-reply, 2018/08/17
- Re: [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations, no-reply, 2018/08/18
- Re: [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations, no-reply, 2018/08/18