[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ipmi: Use proper struct reference for BT vms

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] ipmi: Use proper struct reference for BT vmstate
Date: Tue, 21 Aug 2018 13:00:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 20/08/2018 22:57, address@hidden wrote:
> From: Corey Minyard <address@hidden>
> The vmstate for isa_ipmi_bt was referencing into the bt structure,
> instead create a bt structure separate and use that.
> The version 1 of the BT transfer was fairly broken, if a migration
> occured during an IPMI operation, it is likely the migration would
> be corrupted because I misunderstood the VMSTATE_VBUFFER_UINT32()
> handling, I thought it handled transferring the length field,
> too.  So I just remove support for that.  I doubt anyone is using
> it at this point.
> This also removes the transfer of use_irq, since that should come
> from configuration.
> Signed-off-by: Corey Minyard <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Queued, thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]