[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/12] spice-display: fix qemu_spice_cursor_refre
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PULL 08/12] spice-display: fix qemu_spice_cursor_refresh_bh locking |
Date: |
Tue, 21 Aug 2018 14:06:06 +0200 |
User-agent: |
NeoMutt/20180622 |
On Tue, Aug 21, 2018 at 11:45:20AM +0200, Paolo Bonzini wrote:
> On 21/08/2018 09:45, Gerd Hoffmann wrote:
> > + qemu_mutex_lock(&ssd->lock);
> > if (ssd->cursor) {
> > + QEMUCursor *c = ssd->cursor;
> > assert(ssd->dcl.con);
> > + cursor_get(c);
> > + qemu_mutex_unlock(&ssd->lock);
> > dpy_cursor_define(ssd->dcl.con, ssd->cursor);
>
> Gerd,
>
> this ssd->cursor should be "c" in the call to dpy_cursor_define. My
> apologies; please tell me if you'd like me to send a follow-up fix.
Fixed, pull v2 on the way.
cheers,
Gerd
- [Qemu-devel] [PULL 00/12] Ui 20180821 patches, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 08/12] spice-display: fix qemu_spice_cursor_refresh_bh locking, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 10/12] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 11/12] dmabuf: add y0_top, pass it to spice, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 07/12] spice-display: access ptr_x/ptr_y under Mutex, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 09/12] ui/sdl2: Fix broken -full-screen CLI option, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 02/12] vnc: fix memleak of the "vnc-worker-output" name, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 05/12] doc: switch to modern syntax for VNC TLS setup, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 01/12] ui/sdl2: Remove the obsolete SDL_INIT_NOPARACHUTE flag, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 04/12] sdl2: redraw correctly when scanout_mode enabled., Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 12/12] util: promote qemu_egl_rendernode_open() to libqemuutil, Gerd Hoffmann, 2018/08/21
- [Qemu-devel] [PULL 03/12] ui: use enum to string helpers, Gerd Hoffmann, 2018/08/21