[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/16] linux-user: Split out some simple file
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/16] linux-user: Split out some simple file syscalls |
Date: |
Wed, 22 Aug 2018 15:58:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/21/2018 05:50 PM, Laurent Vivier wrote:
> I don't understand why you need/want to duplicate the list of syscalls here.
>
> If I modify your patch as following, it works without duplicating the list:
>
> diff --git a/linux-user/syscall-file.def.c b/linux-user/syscall-file.def.c
> new file mode 100644
> index 0000000000..78b1bd0467
> --- /dev/null
> +++ b/linux-user/syscall-file.def.c
> @@ -0,0 +1,13 @@
> +SYSCALL_DEF(close, ARG_DEC);
> +#ifdef TARGET_NR_open
> +SYSCALL_DEF(open, ARG_STR, ARG_OPENFLAG, ARG_MODEFLAG);
> +#endif
> +SYSCALL_DEF(openat, ARG_ATDIRFD, ARG_STR, ARG_OPENFLAG, ARG_MODEFLAG);
> +SYSCALL_DEF(read, ARG_DEC, ARG_PTR, ARG_DEC);
> +#ifdef TARGET_NR_readlink
> +SYSCALL_DEF(readlink, ARG_STR, ARG_PTR, ARG_DEC);
> +#endif
> +#ifdef TARGET_NR_readlinkat
> +SYSCALL_DEF(readlinkat, ARG_ATDIRFD, ARG_STR, ARG_PTR, ARG_DEC);
> +#endif
> +SYSCALL_DEF(write, ARG_DEC, ARG_PTR, ARG_DEC);
Sort-of interesting, but I do have other definitions of
syscall structures that do not use this macro.
Please look through e.g. patch 15 and suggest how I might
define mmap2 with your scheme.
r~
- [Qemu-devel] [PATCH v4 04/16] linux-user: Propagate goto efault to return, (continued)
- [Qemu-devel] [PATCH v4 04/16] linux-user: Propagate goto efault to return, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 08/16] configure: Use -Wunused-const-variable, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 09/16] linux-user: Setup split syscall infrastructure, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 11/16] linux-user: Split out preadv, pwritev, readv, writev, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 10/16] linux-user: Split out some simple file syscalls, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 12/16] linux-user: Split out pread64, pwrite64, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 13/16] linux-user: Split out name_to_handle_at, open_by_handle_at, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 15/16] linux-user: Split out memory syscalls, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 14/16] linux-user: Split out ipc syscalls, Richard Henderson, 2018/08/18
- [Qemu-devel] [PATCH v4 16/16] linux-user: Split out some process syscalls, Richard Henderson, 2018/08/18
- Re: [Qemu-devel] [PATCH v4 00/16] linux-user: Split do_syscall, Laurent Vivier, 2018/08/21