[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] postcopy: Synchronize usage of the balloon inhi
Re: [Qemu-devel] [PATCH] postcopy: Synchronize usage of the balloon inhibitor
Thu, 23 Aug 2018 10:14:27 +0200
On Wed, 22 Aug 2018 13:32:24 -0600
Alex Williamson <address@hidden> wrote:
> While the qemu_balloon_inhibit() interface appears rather general purpose,
> postcopy uses it in a last-caller-wins approach with no guarantee of balanced
> inhibits and de-inhibits. Wrap postcopy's usage of the inhibitor to give it
> one vote overall, using the same last-caller-wins approach as previously
> implemented at the balloon level.
> Reported-by: Christian Borntraeger <address@hidden>
> Fixes: 01ccbec7bdf6 ("balloon: Allow multiple inhibit users")
> Signed-off-by: Alex Williamson <address@hidden>
> Note that checkpatch.pl doesn't appreciate the initialization of the
> static variable to false, imo it improves the readability of the code
> in this instance, so I've left it. Shout if you disagree.
I agree that it improves readability.
> If this gets acks I can include it with a pull request for a couple
> other fixes to the original series. Thanks
> migration/postcopy-ram.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>