Re: [Qemu-devel] [PULL 03/74] es1370: simplify MemoryRegionOps

[Peter Maydell]

On 24 August 2018 at 16:04, Peter Maydell <address@hidden> wrote:
> On 21 August 2018 at 18:01, Paolo Bonzini <address@hidden> wrote:
>> Use the automatic subregister extraction from the memory API, and avoid
>> that Coverity complains about missing fallthrough comments.
>
> Hi -- Coverity (CID 1395167) points out that these changes are wrong:

> because these values aren't contiguous:
>
> #define ES1370_REG_DAC1_FRAMEADR    0xc30
> #define ES1370_REG_DAC2_FRAMEADR    0xc38
> #define ES1370_REG_ADC_FRAMEADR     0xd30
>
> so you can't calculate the value of 'd' from the addr
> this way.
>
> (Similarly for the SCOUNT registers.)

...and also for the FRAMECNT registers, CID1395185.

thanks
-- PMM