[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/9] char-pty: remove check for connection on write
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 8/9] char-pty: remove check for connection on write |
Date: |
Tue, 28 Aug 2018 00:23:21 +0200 |
This doesn't give much compared to the 1 second timer: there is no
reliable / unracy way to have slave connect & master write. However,
we can simplify the code around chr_write() since the write lock is no
longer needed for various other char-pty callbacks (see following
patch).
Signed-off-by: Marc-André Lureau <address@hidden>
---
chardev/char-pty.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index 68fd4e20c3..ebd7035c6d 100644
--- a/chardev/char-pty.c
+++ b/chardev/char-pty.c
@@ -134,11 +134,7 @@ static int char_pty_chr_write(Chardev *chr, const uint8_t
*buf, int len)
PtyChardev *s = PTY_CHARDEV(chr);
if (!s->connected) {
- /* guest sends data, check for (re-)connect */
- pty_chr_update_read_handler_locked(chr);
- if (!s->connected) {
- return len;
- }
+ return len;
}
return io_channel_send(s->ioc, buf, len);
}
--
2.18.0.547.g1d89318c48
- [Qemu-devel] [PATCH 1/9] char.h: fix gtk-doc comment style, (continued)
- [Qemu-devel] [PATCH 1/9] char.h: fix gtk-doc comment style, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 4/9] char: update the mux hanlders in class callback, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 7/9] chardev: add a note about frontend sources and context switch, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources, Marc-André Lureau, 2018/08/27
[Qemu-devel] [PATCH 8/9] char-pty: remove check for connection on write,
Marc-André Lureau <=
[Qemu-devel] [PATCH 9/9] char-pty: remove write_lock usage, Marc-André Lureau, 2018/08/27