Re: [Qemu-devel] [PATCH v6 03/13] qapi: remove error checks for event emission

[Peter Xu]

On Mon, Aug 27, 2018 at 02:14:25PM +0200, Markus Armbruster wrote:

[...]

> Let's improve the commit message a bit.  Here's my try:
> 
>     qapi: Drop qapi_event_send_FOO()'s Error ** argument
> 
>     The generated qapi_event_send_FOO() take an Error ** argument.  They
>     can't actually fail, because all they do with the argument is passing it
>     to functions that can't fail: the QObject output visitor, and the
>     @qmp_emit callback, which is either monitor_qapi_event_queue() or
>     event_test_emit().
> 
>     Drop the argument, and pass &error_abort to the QObject output visitor
>     and @qmp_emit instead.

I'm stealing this into my local tree.

> 
> With something like that:
> Reviewed-by: Markus Armbruster <address@hidden>

Thanks for the analysis and r-b; stealing the r-b too.

-- 
Peter Xu