Re: [Qemu-devel] [PATCH 8/9] block: Allow changing 'detect-zeroes' on reopen

[Max Reitz]

On 2018-08-26 16:09, Alberto Garcia wrote:
> 'detect-zeroes' is one of the basic BlockdevOptions available for all
> drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so
> the user cannot change it and doesn't get an error explaining that it
> can't be changed.
> 
> This should update the detect-zeroes setting, but does nothing:
> 
>    (qemu) qemu-io virtio0 "reopen -o detect-zeroes=on"
> 
> This should return an error but also does nothing:
> 
>    (qemu) qemu-io virtio0 "reopen -o discard=off,detect-zeroes=unmap"
> 
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
> 
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block.c               | 63 
> +++++++++++++++++++++++++++++++--------------------
>  include/block/block.h |  1 +
>  2 files changed, 40 insertions(+), 24 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature