[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test |
Date: |
Fri, 31 Aug 2018 10:38:57 +0200 |
From: Marc-André Lureau <address@hidden>
test_qom_set_without_value() is about a bug in infrastructure used by
the QMP core, fixed in commit c489780203. We covered the bug in
infrastructure unit tests (commit bce3035a44). I wrote that test
earlier, to cover QMP level as well, the test could go into qmp-test.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
tests/qmp-test.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index b347228..2b923f0 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -321,6 +321,19 @@ static void test_qmp_preconfig(void)
qtest_quit(qs);
}
+static void test_qom_set_without_value(void)
+{
+ QTestState *qts;
+ QDict *resp;
+
+ qts = qtest_init(common_args);
+ resp = qtest_qmp(qts, "{'execute': 'qom-set', 'arguments':"
+ " { 'path': '/machine', 'property': 'rtc-time' } }");
+ g_assert_nonnull(resp);
+ qmp_assert_error_class(resp, "GenericError");
+ qtest_quit(qts);
+}
+
int main(int argc, char *argv[])
{
g_test_init(&argc, &argv, NULL);
@@ -328,6 +341,7 @@ int main(int argc, char *argv[])
qtest_add_func("qmp/protocol", test_qmp_protocol);
qtest_add_func("qmp/oob", test_qmp_oob);
qtest_add_func("qmp/preconfig", test_qmp_preconfig);
+ qtest_add_func("qmp/qom-set-without-value", test_qom_set_without_value);
return g_test_run();
}
--
1.8.3.1
[Qemu-devel] [PULL 6/9] tests: add qmp_assert_error_class(), Thomas Huth, 2018/08/31
[Qemu-devel] [PULL 5/9] tests/libqos: Utilize newer glib spawn check, Thomas Huth, 2018/08/31
[Qemu-devel] [PULL 2/9] Remove the deprecated -nodefconfig option, Thomas Huth, 2018/08/31
[Qemu-devel] [PULL 3/9] Remove the deprecated options -startdate, -localtime and -rtc-td-hack, Thomas Huth, 2018/08/31
[Qemu-devel] [PULL 4/9] net: Remove the deprecated -tftp, -bootp, -redir and -smb options, Thomas Huth, 2018/08/31