[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/11] aspeed/smc: fix default read value
From: |
Cédric Le Goater |
Subject: |
[Qemu-devel] [PATCH 06/11] aspeed/smc: fix default read value |
Date: |
Fri, 31 Aug 2018 12:38:13 +0200 |
0xFFFFFFFF should be returned for non implemented registers.
Signed-off-by: Cédric Le Goater <address@hidden>
---
hw/ssi/aspeed_smc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 1270842dcf0c..6045ca11b969 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -665,12 +665,12 @@ static uint64_t aspeed_smc_read(void *opaque, hwaddr
addr, unsigned int size)
addr == s->r_ce_ctrl ||
addr == R_INTR_CTRL ||
(addr >= R_SEG_ADDR0 && addr < R_SEG_ADDR0 + s->ctrl->max_slaves) ||
- (addr >= s->r_ctrl0 && addr < s->r_ctrl0 + s->num_cs)) {
+ (addr >= s->r_ctrl0 && addr < s->r_ctrl0 + s->ctrl->max_slaves)) {
return s->regs[addr];
} else {
qemu_log_mask(LOG_UNIMP, "%s: not implemented: 0x%" HWADDR_PRIx "\n",
__func__, addr);
- return 0;
+ return -1;
}
}
--
2.17.1
- [Qemu-devel] [PATCH 00/11] aspeed: misc fixes and enhancements (SMC), Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 01/11] aspeed/timer: fix compile breakage with clang 3.4.2, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 02/11] hw/arm/aspeed: change the FMC flash model of the AST2500 evb, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 03/11] hw/arm/aspeed: Add an Aspeed machine class, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 04/11] hw/arm/aspeed: add a 'mmio-exec' property to boot from the FMC flash module, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 05/11] aspeed/smc: fix some alignment issues, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 06/11] aspeed/smc: fix default read value,
Cédric Le Goater <=
- [Qemu-devel] [PATCH 07/11] aspeed/smc: add a 'sdram_base' and 'max-ram-size' properties, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 08/11] aspeed/smc: add support for DMAs, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 09/11] aspeed/smc: add DMA calibration settings, Cédric Le Goater, 2018/08/31
- [Qemu-devel] [PATCH 10/11] aspeed/smc: inject errors in DMA checksum, Cédric Le Goater, 2018/08/31
- Re: [Qemu-devel] [PATCH 00/11] aspeed: misc fixes and enhancements (SMC), Joel Stanley, 2018/08/31