[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/6] monitor: accept input on resume
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 2/6] monitor: accept input on resume |
Date: |
Sat, 1 Sep 2018 13:17:12 +0200 |
From: Marc-André Lureau <address@hidden>
A chardev may stop trying to write if the associated can_read()
callback returned 0. This happens when the monitor is suspended.
The frontend is supposed to call qemu_chr_fe_accept_input() when it is
ready to accept data again.
An issue was observed with a spice port: pending commands may be
delayed, as the chardev is not flushed. Most chardev don't use the
accept_input() callback, and instead check regularly if they can
write. The ones that do use it are braille, mux, msmouse,
spice (abstract), spicevmc, spiceport, wctablet.
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor.c b/monitor.c
index c049776603..c1add2ce09 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4411,6 +4411,7 @@ void monitor_resume(Monitor *mon)
assert(mon->rs);
readline_show_prompt(mon->rs);
}
+ qemu_chr_fe_accept_input(&mon->chr);
}
trace_monitor_suspend(mon, -1);
}
--
2.17.1
- [Qemu-devel] [PULL 0/6] Monitor patches for 2018-09-01, Markus Armbruster, 2018/09/01
- [Qemu-devel] [PULL 6/6] monitor: no need to save need_resume, Markus Armbruster, 2018/09/01
- [Qemu-devel] [PULL 4/6] qmp: constify qmp_is_oob(), Markus Armbruster, 2018/09/01
- [Qemu-devel] [PULL 2/6] monitor: accept input on resume,
Markus Armbruster <=
- [Qemu-devel] [PULL 5/6] Revert "qmp: isolate responses into io thread", Markus Armbruster, 2018/09/01
- [Qemu-devel] [PULL 3/6] monitor: consitify qmp_send_response() QDict argument, Markus Armbruster, 2018/09/01
- [Qemu-devel] [PULL 1/6] monitor: simplify monitor_qmp_setup_handlers_bh, Markus Armbruster, 2018/09/01
- Re: [Qemu-devel] [PULL 0/6] Monitor patches for 2018-09-01, Peter Maydell, 2018/09/24