[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes'

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' on reopen
Date: Wed, 5 Sep 2018 14:52:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-09-03 16:34, Alberto Garcia wrote:
> 'detect-zeroes' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare(), so any attempt
> to change it results in an error:
>    (qemu) qemu-io virtio0 "reopen -o detect-zeroes=on"
>    Cannot change the option 'detect-zeroes'
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
> Signed-off-by: Alberto Garcia <address@hidden>
> Cc: Max Reitz <address@hidden>
> ---
>  block.c               | 63 
> +++++++++++++++++++++++++++++++--------------------
>  include/block/block.h |  1 +
>  2 files changed, 40 insertions(+), 24 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]