[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor |
Date: |
Wed, 5 Sep 2018 09:09:19 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 09/05/2018 06:43 AM, Max Reitz wrote:
> On 2018-09-04 19:09, John Snow wrote:
>> For purposes of minimum code movement, refactor the mirror_exit
>> callback to use the post-finalization callbacks in a trivial way.
>>
>> Signed-off-by: John Snow <address@hidden>
>> ---
>> block/mirror.c | 34 +++++++++++++++++++++++++++-------
>> 1 file changed, 27 insertions(+), 7 deletions(-)
>
> Reviewed-by: Max Reitz <address@hidden>
>
> (Although I believe the ?: hunk from the previous patch should be here.
> Also note that we have a couple of places that make use of the GNU
> extension for "?:" as a binary operator (as in "x ?: y" returns x if
> x != 0). Just in case you find "s->to_replace ?: src" as appealing as I
> do.)
>
Ah, I wasn't sure that was OK to use. Meh, since I goofed up the last
patch I'll use that version.
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v4 08/15] tests/blockjob: replace Blockjob with Job, John Snow, 2018/09/04
[Qemu-devel] [PATCH v4 09/15] tests/test-blockjob: remove exit callback, John Snow, 2018/09/04
[Qemu-devel] [PATCH v4 14/15] qapi/block-stream: expose new job properties, John Snow, 2018/09/04
[Qemu-devel] [PATCH v4 15/15] block/backup: qapi documentation fixup, John Snow, 2018/09/04
[Qemu-devel] [PATCH v4 11/15] jobs: remove .exit callback, John Snow, 2018/09/04