Re: [Qemu-devel] [PATCH 5/6] test-qht: test deletion of the last entry in a bucket

[Alex Bennée]

Emilio G. Cota <address@hidden> writes:

> This improves coverage by one (!) LoC in qht.c, bringing the
> coverage rate up from 90.00% to 90.28%.
>
> Signed-off-by: Emilio G. Cota <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  tests/test-qht.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tests/test-qht.c b/tests/test-qht.c
> index 05b1d6807a..77666e8c5f 100644
> --- a/tests/test-qht.c
> +++ b/tests/test-qht.c
> @@ -172,9 +172,20 @@ static void qht_do_test(unsigned int mode, size_t 
> init_entries)
>
>      qht_init(&ht, is_equal, 0, mode);
>      rm_nonexist(0, 4);
> +    /*
> +     * Test that we successfully delete the last element in a bucket.
> +     * This is a hard-to-reach code path when resizing is on, but without
> +     * resizing we can easily hit it if init_entries <= 1.
> +     * Given that the number of elements per bucket can be 4 or 6 depending 
> on
> +     * the host's pointer size, test the removal of the 4th and 6th elements.
> +     */
>      insert(0, 4);
>      rm_nonexist(5, 6);
> -    insert(4, 6);
> +    rm(3, 4);
> +    check_n(3);
> +    insert(3, 6);
> +    rm(5, 6);
> +    check_n(5);
>      rm_nonexist(7, 8);
>      iter_rm_mod(1);


--
Alex Bennée