[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 00/16] jobs: Job Exit Refactoring Pt 2

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 00/16] jobs: Job Exit Refactoring Pt 2
Date: Sat, 8 Sep 2018 01:29:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-09-06 15:02, John Snow wrote:
> This is part two of a two part series that refactors the exit logic
> of jobs.
> This series forces all jobs to use the "finalize" semantics that were
> introduced previously, but only exposed via the backup jobs.
> Patches 1-3 add plumbing for the auto-dismiss and auto-finalize flags
> but do not expose these via QAPI/QMP.
> Patches 4-7 refactor the .exit() callbacks into the component pieces
> of .prepare(), .commit(), .abort() and .clean(). Except mirror, which
> I cheat with.
> Patches 8-10 remove the last usages of .exit in a test.
> Patche 11 removes the .exit callback and the machinery to invoke it.
> Patches 12-14 expose the new QMP options to all of the jobs.
> Patch 15 is a doc fixup.

Thanks, fixed the capitalization in patch 4's commit message, added the
mirror_exit() comment you proposed in patch 6, and applied to my block



Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]