[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/3] scsi: replace lsi53c895a_create() and ls

From: Hervé Poussineau
Subject: Re: [Qemu-devel] [PATCH v2 0/3] scsi: replace lsi53c895a_create() and lsi53c810_create() functions
Date: Sat, 8 Sep 2018 08:30:37 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Le 07/09/2018 à 14:56, Mark Cave-Ayland a écrit :
As part of an upcoming 40p patchset I have a requirement to change the PCI
configuration of the LSI SCSI. However since commits a64aa5785d "hw: Deprecate 
if=scsi with non-onboard HBAs" and b891538e81 "hw/ppc/prep: Fix implicit 
creation of
"-drive if=scsi", the lsi53c8*_create() wrapper functions don't return the 
state itself.

This patchset replaces the lsi53c895a_create() and lsi53c810_create() functions
with a single lsi53c8xx_handle_legacy_cmdline() function as suggested by Thomas,
which makes the caller responsible for initing the LSI SCSI device and hence
allowing it to be configured as required.

Signed-off-by: Mark Cave-Ayland <address@hidden>

- Don't split LSIState into separate lsi53c895a.h header but instead use a new
   lsi53c8xx_handle_legacy_cmdline() function as suggested by Thomas

Mark Cave-Ayland (3):
   scsi: add lsi53c8xx_handle_legacy_cmdline() function
   scsi: move lsi53c8xx_create() callers to
   scsi: remove unused lsi53c895a_create() and lsi53c810_create()

  hw/arm/realview.c    |  3 ++-
  hw/arm/versatilepb.c |  3 ++-
  hw/hppa/machine.c    |  4 +++-
  hw/ppc/prep.c        |  4 +++-
  hw/scsi/lsi53c895a.c | 11 ++---------
  include/hw/pci/pci.h |  3 +--
  6 files changed, 13 insertions(+), 15 deletions(-)

Reviewed-by: Hervé Poussineau <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]