Re: [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests

[Alex Bennée]

Emilio G. Cota <address@hidden> writes:

> By leveraging berkeley's softfloat and testfloat.
>
> fp-test.c is derived from testfloat's testsoftfloat.c. To ease
> the tracking of upstream changes to the latter file, fp-test.c
> keeps the original camel-case variable naming, and includes
> most new code via wrap.inc.c.
>
> Most changes to the original code are simple style changes,
> although a couple of not-so-subtle modifications have been
> made (noted with XXX in the code), namely:
>
> - We do not test ROUND_ODD, since not all of our primitives
>   support it (e.g. fp16)
>
> - Do not test !exact in round-to-integer, since it is not
>   implemented in QEMU (this flag was added to softfloat v3).
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  configure              |    2 +
>  tests/fp/platform.h    |   41 ++
>  tests/fp/fp-test.c     | 1052 ++++++++++++++++++++++++++++++++++++++++
>  tests/fp/wrap.inc.c    |  600 +++++++++++++++++++++++
>  tests/Makefile.include |    3 +
>  tests/fp/.gitignore    |    1 +
>  tests/fp/Makefile      |  591 ++++++++++++++++++++++
>  7 files changed, 2290 insertions(+)

<snip>

> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 87c81d1dcc..363f133101 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -657,6 +657,9 @@ tests/qht-bench$(EXESUF): tests/qht-bench.o 
> $(test-util-obj-y)
>  tests/test-bufferiszero$(EXESUF): tests/test-bufferiszero.o 
> $(test-util-obj-y)
>  tests/atomic_add-bench$(EXESUF): tests/atomic_add-bench.o $(test-util-obj-y)
>
> +tests/fp/%:
> +     $(MAKE) -C $(dir $@) $(notdir $@)
> +

This isn't enough to cause the build to be included in make check or
indeed be run. Perhaps that should be included in a new patch in the
series?

>  tests/test-qdev-global-props$(EXESUF): tests/test-qdev-global-props.o \
>       hw/core/qdev.o hw/core/qdev-properties.o hw/core/hotplug.o\
>       hw/core/bus.o \
<snip>

--
Alex Bennée