Re: [Qemu-devel] [libvirt] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

[Eric Blake]

On 9/10/18 12:49 PM, Eduardo Habkost wrote:

> I was considering something like this:
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 060e015be6..74f6a64b8b 100644
> --- a/qemu-deprecated.texi

> +++ b/qemu-options.hx
> @@ -155,8 +155,13 @@ to 4.
>   For the PC target, the number of @var{cores} per socket, the number
>   of @var{threads} per cores and the total number of @var{sockets} can be
>   specified. Missing values will be computed. If any on the three values is

while here, s/on/of/

> -given, the total number of CPUs @var{n} can be omitted. @var{maxcpus}
> -specifies the maximum number of hotpluggable CPUs.
> +given, the total number of CPUs @var{n} can be omitted.
> +
> address@hidden specifies the maximum number of hotpluggable CPUs
> +and should be equal to @address@hidden * @var{cores} * @var{threads}}
> +(even if @var{sockets}, @var{cores}, or @var{threads} is omitted
> +and computed automatically).
> +
>   ETEXI
>   
>   DEF("numa", HAS_ARG, QEMU_OPTION_numa,

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org