[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in u
Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode
Tue, 11 Sep 2018 09:46:20 +0000
> > - organize the changes in the form of patch series
> What kind of granularity do you have in mind? The patch is quite small with
> 79 insertions and 1 deletion in total.
For patch organization, you may find these links useful:
Patch size is not the best criterium while organizing patches.
One good organization of your changes would be:
Patch 1: Add preprocessor constants INSN_R5900 and CPU_R5900
Patch 2: Amend OPC_MULT/OPC_MULTU handling for R5900
Patch 3: Update cpu_get_model() for R5900 case
Patch 4: Add defintion of R5900 CPU
This will allow us to discuss individual changes separately.