Re: [Qemu-devel] [PATCH v2 3/3] block/rbd: add iotest for rbd legacy keyvalue filename parsing

[Eric Blake]

On 9/11/18 3:43 PM, Jeff Cody wrote:
> This is a small test that will check for the ability to parse
> both legacy and modern options for rbd.
>
> The way the test is set up is for failure to occur, but without
> having to wait to timeout on a non-existent rbd server.  The error
> messages in the success path show that the arguments were parsed.
>
> The failure behavior prior to the patch series that has this test, is
> qemu-img complaining about mandatory options (e.g. 'pool') not being
> provided.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>   tests/qemu-iotests/231     | 62 ++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/231.out |  9 ++++++
>   tests/qemu-iotests/group   |  1 +
>   3 files changed, 72 insertions(+)
>   create mode 100755 tests/qemu-iotests/231
>   create mode 100644 tests/qemu-iotests/231.out

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org