Re: [Qemu-devel] [PATCH v3 4/4] block/rbd: add deprecation documenation for filename keyvalue pairs

[Eric Blake]

[MAINTAINERS says libvir-list should have been cc'd; not sure why that 
didn't happen]

On 9/11/18 4:34 PM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody <address@hidden>

In the subject: s/documenation/documentation/

> ---
>   qemu-deprecated.texi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 1b9c007f12..4df8ac442d 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -190,6 +190,13 @@ used instead.
>   In order to prevent QEMU from automatically opening an image's backing
>   chain, use ``"backing": null'' instead.
>   
> address@hidden "rbd keyvalue pair encoded filenames": "" (since 3.1.0)
> +
> +Options for ``rbd'' should be specified according to its runtime options,
> +like other block drivers.  Legacy parsing of keyvalue pair encoded
> +filenames is useful to open images with the old format for backing files;
> +These image files should be updated to use the current format.

Can we give an example?  Cribbing from patch 3, an example might look 
like changing:

json:{"file.driver":"rbd", "file.filename":"rbd:rbd/name"}

into:

json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"}

I'll let Peter or John comment on whether libvirt's RBD pool handler is 
impacted by this deprecation, but it seems reasonable to me.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org