[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 24/25] slirp: fix ipv6 timers
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH v6 24/25] slirp: fix ipv6 timers |
Date: |
Wed, 12 Sep 2018 10:45:01 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Pavel Dovgalyuk, le mer. 12 sept. 2018 11:20:07 +0300, a ecrit:
> ICMP implementation for IPv6 uses timers based on virtual clock.
> This is incorrect because this service is not related to the guest state,
> and its events should not be recorded and replayed.
> This patch changes using virtual clock to the new virtual_ext clock.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
As discussed previously
Reviewed-by: Samuel Thibault <address@hidden>
> ---
> slirp/ip6_icmp.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c
> index ee333d0..3f41187 100644
> --- a/slirp/ip6_icmp.c
> +++ b/slirp/ip6_icmp.c
> @@ -17,7 +17,7 @@ static void ra_timer_handler(void *opaque)
> {
> Slirp *slirp = opaque;
> timer_mod(slirp->ra_timer,
> - qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + NDP_Interval);
> + qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_EXT) + NDP_Interval);
> ndp_send_ra(slirp);
> }
>
> @@ -27,9 +27,10 @@ void icmp6_init(Slirp *slirp)
> return;
> }
>
> - slirp->ra_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL, ra_timer_handler,
> slirp);
> + slirp->ra_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL_EXT,
> + ra_timer_handler, slirp);
> timer_mod(slirp->ra_timer,
> - qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + NDP_Interval);
> + qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_EXT) + NDP_Interval);
> }
>
> void icmp6_cleanup(Slirp *slirp)
>
>
--
Samuel
<T> csp.tar.gz: ascii text
-+- #ens-mim - vive les browsers qui prennent des initiatives à la con -+-
- Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation, (continued)
[Qemu-devel] [PATCH v6 22/25] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2018/09/12
[Qemu-devel] [PATCH v6 23/25] timer: introduce new virtual clock, Pavel Dovgalyuk, 2018/09/12
[Qemu-devel] [PATCH v6 24/25] slirp: fix ipv6 timers, Pavel Dovgalyuk, 2018/09/12
- Re: [Qemu-devel] [PATCH v6 24/25] slirp: fix ipv6 timers,
Samuel Thibault <=
[Qemu-devel] [PATCH v6 25/25] ui: fix virtual timers, Pavel Dovgalyuk, 2018/09/12
Re: [Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging, Paolo Bonzini, 2018/09/13
[Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging, Artem Pisarenko, 2018/09/30