Re: [Qemu-devel] [PATCH] Fix breakpoints in nios2 user-mode emulation.

[Richard Henderson]

On 09/11/2018 02:29 PM, Sandra Loosemore wrote:
> Without this patch, QEMU exits immediately when it execution stops at
> a breakpoint, instead of reporting it to GDB.
> 
> Signed-off-by: Sandra Loosemore <address@hidden>
> ---
>  linux-user/nios2/cpu_loop.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
> index dac7a06..a5ae37f 100644
> --- a/linux-user/nios2/cpu_loop.c
> +++ b/linux-user/nios2/cpu_loop.c
> @@ -71,6 +71,9 @@ void cpu_loop(CPUNios2State *env)
>                  gdbsig = TARGET_SIGTRAP;
>                  break;
>              }
> +        case EXCP_DEBUG:
> +            gdbsig = TARGET_SIGTRAP;
> +            break;

This really isn't complete.  You set gdbsig from odd places instead of using
queue_signal; you fail to honor the return value from gdb_handlesig.

But I suppose those should be separate patches, so
Reviewed-by: Richard Henderson <address@hidden>


r~