Re: [Qemu-devel] [PATCH v3] vmdk: align end of file to a sector boundary

[Fam Zheng]

On Thu, 09/13 16:29, address@hidden wrote:
> From: yuchenlin <address@hidden>
> 
> There is a rare case which the size of last compressed cluster
> is larger than the cluster size, which will cause the file is
> not aligned at the sector boundary.
> 
> There are three reasons to do it. First, if vmdk doesn't align at
> the sector boundary, there may be many undefined behaviors,
> such as, in vbox it will show VMDK: Compressed image is corrupted
> 'syno-vm-disk1.vmdk' (VERR_ZIP_CORRUPTED) when we try to import an
> ova with unaligned vmdk. Second, all the cluster_sector is aligned
> to sector, the last one should be like this, too. Third, it ease
> reading with sector based I/Os.
> 
> Signed-off-by: yuchenlin <address@hidden>

Reviewed-by: Fam Zheng <address@hidden>