[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v8 1/2] vl.c deprecate incorrect CPUs topology

From: Igor Mammedov
Subject: [Qemu-devel] [PATCH v8 1/2] vl.c deprecate incorrect CPUs topology
Date: Thu, 13 Sep 2018 13:06:01 +0200

-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
so that total number of logical CPUs [sockets * cores * threads]
would be equal to [maxcpus], however historically we didn't have
such check in QEMU and it is possible to start VM with an invalid
Deprecate invalid options combination so we can make sure that
the topology VM started with is always correct in the future.
Users with an invalid sockets/cores/threads/maxcpus values should
fix their CLI to make sure that
   [sockets * cores * threads] == [maxcpus]

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Andrew Jones <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
  - drop repetitive sentence:
     "In other words: ..."
   (Eric Blake <address@hidden>)
  - add corrections to deprication doc formulas/math/section title
  - drop Note section
      (Eduardo Habkost <address@hidden>)
  - s/socket/sockets/, the same for core, thread in subsection
    (Andrew Jones <address@hidden>)
  - extend deprecation doc, adding that maxcpus should be multiple of
    present on CLI [sockets/cores/threads] options
    (Eduardo Habkost <address@hidden>)
  - missed dot comment, fix it with s/./,/ (Andrew Jones <address@hidden>)
  - more spelling fixes (Andrew Jones <address@hidden>)
  - place deprecation check after (sockets * cores * threads > max_cpus) check
    (Eduardo Habkost <address@hidden>)
  - spelling&&co fixes (Andrew Jones <address@hidden>)
 qemu-deprecated.texi | 12 ++++++++++++
 vl.c                 |  7 +++++++
 2 files changed, 19 insertions(+)

diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007..df717df 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -139,6 +139,18 @@ The 'file' driver for drives is no longer appropriate for 
character or host
 devices and will only accept regular files (S_IFREG). The correct driver
 for these file types is 'host_cdrom' or 'host_device' as appropriate.
address@hidden -smp (invalid topologies) (since 3.1)
+CPU topology properties should describe whole machine topology including
+possible CPUs.
+However, historically it was possible to start QEMU with an incorrect topology
+where @address@hidden <= @var{sockets} * @var{cores} * @var{threads} < 
+which could lead to an incorrect topology enumeration by the guest.
+Support for invalid topologies will be removed, the user must ensure
+topologies described with -smp include all possible cpus, i.e.
+  @address@hidden * @var{cores} * @var{threads} = @var{maxcpus}}.
 @section QEMU Machine Protocol (QMP) commands
 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
diff --git a/vl.c b/vl.c
index 5ba06ad..7fd700e 100644
--- a/vl.c
+++ b/vl.c
@@ -1246,6 +1246,13 @@ static void smp_parse(QemuOpts *opts)
+        if (sockets * cores * threads != max_cpus) {
+            warn_report("Invalid CPU topology deprecated: "
+                        "sockets (%u) * cores (%u) * threads (%u) "
+                        "!= maxcpus (%u)",
+                        sockets, cores, threads, max_cpus);
+        }
         smp_cpus = cpus;
         smp_cores = cores;
         smp_threads = threads;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]