[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate

From: Thomas Huth
Subject: Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate
Date: Mon, 17 Sep 2018 10:55:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-09-17 10:31, Fam Zheng wrote:
> This option is added together with scsi-disk but is never honoured,
> becuase we don't emulate the VPD page for scsi-block. We could intercept
> and inject the user specified value like for max xfer len, but it's
> probably not helpful since the intent of 070f80095ad was for random
> entropy aspects, not for performance. If emulated rotation rate is
> desired, scsi-hd is more suitable.
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> RFC to discuss about if we want to keep the option. Another possibility
> is, naturally, to actually write code to make use of the option.

As far as I've understood, scsi-disk is considered to be legacy anyway
and scsi-cd or scsi-hd should rather always be used instead. Thus
another idea that was mentioned in the past already is: Should we maybe
rather deprecate the whole "scsi-disk" device? Or deprecate
"media=cdrom" and make this an alias to "scsi-hd" instead?

Independent of that discussion, I think your patch is fine, it does
certainly not make sense to implement this for a legacy device anymore.
But please also add a deprecation note to qemu-deprecated.texi to mark
it as deprecated "officially".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]