[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/35] target/i386: access cpu->interrupt_reques

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 11/35] target/i386: access cpu->interrupt_request with atomics
Date: Tue, 18 Sep 2018 14:04:35 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 9/17/18 9:30 AM, Emilio G. Cota wrote:
>      cpu_reset(cs);
> -    cs->interrupt_request = sipi;
> +    atomic_mb_set(&cs->interrupt_request, sipi);
>      memcpy(&env->start_init_save, &save->start_init_save,

Why does this need a memory barrier?

Anyway, I think a bare mechanical conversion would be best
for the first patch and then extra barriers added separately
and with a description of why.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]