Re: [Qemu-devel] [PATCH v2 3/4] net/slirp: Deprecate the [hub_id name] parameter tuple

[Philippe Mathieu-Daudé]

On 9/20/18 10:50 AM, Thomas Huth wrote:
> The "name" in the [hub_id name] parameter tuple is the same as a
> "netdev_id" (which should be unique), so specifying the hub_id here
> is just redundant (it was likely just necessary in the past when
> the network subsystem was still using "vlans" only and when it did
> not use unique "id"s yet).
> 
> Signed-off-by: Thomas Huth <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  net/slirp.c          | 2 ++
>  qemu-deprecated.texi | 7 +++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/net/slirp.c b/net/slirp.c
> index c18060f..c93b64d 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -404,6 +404,8 @@ static SlirpState *slirp_lookup(Monitor *mon, const char 
> *hub_id,
>                  monitor_printf(mon, "unrecognized (hub-id, stackname) 
> pair\n");
>                  return NULL;
>              }
> +            warn_report("Using 'hub-id' is deprecated, specify the netdev id 
> "
> +                        "directly instead");
>          } else {
>              nc = qemu_find_netdev(name);
>              if (!nc) {
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 60fd7f7..23fa78b 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -104,6 +104,13 @@ The ``query-cpus'' command is replaced by the 
> ``query-cpus-fast'' command.
>  The ``arch'' output member of the ``query-cpus-fast'' command is
>  replaced by the ``target'' output member.
>  
> address@hidden System emulator human monitor commands
> +
> address@hidden The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' 
> (since 3.1)
> +
> +The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and
> +'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}.
> +
>  @section System emulator devices
>  
>  @subsection ivshmem (since 2.6.0)
>