Re: [Qemu-devel] [PATCH 3/3] linux-user: implement special usbfs ioctls.

[Laurent Vivier]

Le 19/09/2018 à 10:04, Cortland Tölva a écrit :
> Userspace submits a USB Request Buffer to the kernel, optionally
> discards it, and finally reaps the URB.  Thunk buffers from target
> to host and back.
> 
> Tested by running an i386 scanner driver on ARMv7.  Neither the
> discardurb ioctl nor the kernel's updating the argument to the
> reap ioctl with a pointer to a reaped URB are exercised by this.
> 
> Signed-off-by: Cortland Tölva <address@hidden>
> ---
>  linux-user/ioctls.h  |   9 +++
>  linux-user/syscall.c | 168 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 177 insertions(+)
> 
It looks good (for what I understand of usbdevfs...), please move the
usbdevfs_urb parts from PATCH 2 to this one.

Reviewed-by: Laurent Vivier <address@hidden>

Thanks,
LAurent