Re: [Qemu-devel] [PATCH 2/2] monitor: delay monitor iothread creation

[Peter Xu]

On Fri, Sep 21, 2018 at 10:28:56AM +0200, Wolfgang Bumiller wrote:

[...]

> @@ -4738,11 +4744,13 @@ void monitor_cleanup(void)
>      /* QEMUBHs needs to be deleted before destroying the I/O thread */
>      qemu_bh_delete(qmp_dispatcher_bh);
>      qmp_dispatcher_bh = NULL;
> -    qemu_bh_delete(qmp_respond_bh);
> -    qmp_respond_bh = NULL;
> +    if (mon_iothread) {
> +        qemu_bh_delete(qmp_respond_bh);

qmp_respond_bh should have been removed.  Please rebase with master
and repost.  When do, feel free to add a cover letter as Eric
suggested.

Otherwise it looks good to me.

Thanks,

> +        qmp_respond_bh = NULL;
>  
> -    iothread_destroy(mon_iothread);
> -    mon_iothread = NULL;
> +        iothread_destroy(mon_iothread);
> +        mon_iothread = NULL;
> +    }
>  }

-- 
Peter Xu