Re: [Qemu-devel] [PULL 0/5] Linux user for 3.1 patches

[Laurent Vivier]

Le 25/09/2018 à 15:48, Peter Maydell a écrit :
> On 25 September 2018 at 09:54, Laurent Vivier <address@hidden> wrote:
>> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>>
>>   Merge remote-tracking branch 
>> 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 
>> 16:44:20 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/linux-user-for-3.1-pull-request
>>
>> for you to fetch changes up to edbbf43a14d95eb8c39bda0dc9774bb47966b7c0:
>>
>>   linux-user: do setrlimit selectively (2018-09-18 17:59:57 +0200)
>>
>> ----------------------------------------------------------------
>> - some fixes for setrlimit() and write()
>> - fixes ELF loader when host page size is greater than target page size
>> - add SO_LINGER to getsockopt()/setsockopt()
>> - move TargetFdTrans from syscall.c
>>
>> ----------------------------------------------------------------
> 
> Hi. This fails to compile on my aarch64 build host (which is running
> Ubuntu 14.04.5 LTS):
> 
> /home/pm215/qemu/linux-user/fd-trans.c:260:35: error: ‘struct
> nlmsghdr’ declared inside parameter list [-Werror]
>  static void tswap_nlmsghdr(struct nlmsghdr *nlh)
>                                    ^
> /home/pm215/qemu/linux-user/fd-trans.c:260:35: error: its scope is
> only this definition or declaration, which is probably not what you
> want [-Werror]
> /home/pm215/qemu/linux-user/fd-trans.c: In function ‘tswap_nlmsghdr’:
> /home/pm215/qemu/linux-user/fd-trans.c:262:8: error: dereferencing
> pointer to incomplete type
>      nlh->nlmsg_len = tswap32(nlh->nlmsg_len);
>         ^
> (and various follow-on errors)
> 
> I think this is because linux-user/fd-trans.c is missing
> the #include <linux/netlink.h> which syscall.c has, so the
> code doesn't compile when it's moved to the new file.

I'll update this and try a build on Ubuntu 14.04.5.

Thank you,
Laurent