[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 2/3] qapi: bitmap-merge: document name change

From: Eric Blake
Subject: [Qemu-devel] [PULL 2/3] qapi: bitmap-merge: document name change
Date: Wed, 26 Sep 2018 21:54:26 -0500

From: John Snow <address@hidden>

We named these using underscores instead of the preferred dash,
document this nearby so we cannot possibly forget to rectify this
when we remove the 'x-' prefixes when the feature becomes stable.

We do not implement the change ahead of time to avoid more work
for libvirt to do in order to figure out how to use the beta version
of the API needlessly.

Reported-by: Eric Blake <address@hidden>
Signed-off-by: John Snow <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
[eblake: typo fix]
Signed-off-by: Eric Blake <address@hidden>
 qapi/block-core.json | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index ac3b48ee54e..58ec9931c7f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1935,6 +1935,8 @@
 # @x-block-dirty-bitmap-merge:
+# FIXME: Rename @src_name and @dst_name to src-name and dst-name.
 # Merge @src_name dirty bitmap to @dst_name dirty bitmap. @src_name dirty
 # bitmap is unchanged. On error, @dst_name is unchanged.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]