Re: [Qemu-devel] [PATCH v5 6/8] target/mips: Define the R5900 CPU

[Fredrik Noring]

Thank you for your reviews, Philippe,

> Fredrik: maybe you can simply name the C790 in the comment pointing to
> the DS documentation.

Sure, I will do that for v6! I am also adding some of Maciej's notes on the
differences between the C790 and the R5900, along with PRId 0X2E00 as noted
by Jürgen:

    {
        /*
         * The Toshiba TX System RISC TX79 Core Architecture manual
         *
         * http://www.lukasz.dk/files/tx79architecture.pdf
         *
         * describes the C790 processor which is a follow-up to the R5900.
         * There are a few notable differences in that the R5900 FPU
         *
         * - is not fully IEEE 754-1985 compliant,
         * - does not implement double format, and
         * - its machine code is nonstandard.
         */
        .name = "R5900",
        .CP0_PRid = 0x00002E00,

> Fredrik, except the linux-user part for kernel FPU emulation that I
> don't feel confident to review, the rest of this patch looks OK to me:
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Would you rather have an acked-by as a less formal "looks good to me" tag?

I anticipate significant changes to the notes and commit messages in v6,
so all previous tags ought to be reset for that reason, I think.

Fredrik