Re: [Qemu-devel] [PATCH v3 0/5] dirty-bitmaps: fix QMP command permissions

[John Snow]

On 09/26/2018 10:23 PM, Eric Blake wrote:
> On 9/25/18 6:49 PM, John Snow wrote:
>> based on: jsnow/bitmaps staging branch
>>
>> This series builds on a previous standalone patch and adjusts
>> the permission for all (or most) of the QMP bitmap commands.
>>
>> John Snow (5):
>>    block/dirty-bitmaps: add user_modifiable status checker
>>    block/dirty-bitmaps: fix merge permissions
>>    block/dirty-bitmaps: allow clear on disabled bitmaps
>>    block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps
>>    block/backup: prohibit backup from using in-use bitmaps
>>
>>   block/dirty-bitmap.c         | 13 +++++---
>>   blockdev.c                   | 75
>> ++++++++++++++++++++------------------------
>>   include/block/dirty-bitmap.h |  1 +
>>   3 files changed, 44 insertions(+), 45 deletions(-)
> 
> Should there be any testsuite coverage of these changes?
> 

Ideally, it's just that 124 is a bit of a mess at the moment. Maybe I'll
start a new file for simpler interface testing...