[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Proc
From: |
Halil Pasic |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model |
Date: |
Fri, 28 Sep 2018 15:57:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 09/27/2018 12:54 AM, Tony Krowiak wrote:
> From: Tony Krowiak <address@hidden>
>
> Introduces the base object model for virtualizing AP devices.
>
[..]
> +
> +static char *vfio_ap_bus_get_dev_path(DeviceState *dev)
Cover letter states you want to remove vifo_ap references form the bus. Sane
thing to do as this would also be the bus we would like to plug an emulated
ap device into (if these get implemented).
There are a couple of such references that survived around this comment.
> +{
> + /* at most one */
> + return g_strdup_printf("/1");
> +}
> +
> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data)
> +{
> + BusClass *k = BUS_CLASS(klass);
> +
> + k->get_dev_path = vfio_ap_bus_get_dev_path;
> + /* More than one vfio-ap device does not make sense */
> + k->max_dev = 1;
> +}
> +
> +static const TypeInfo vfio_ap_bus_info = {
> + .name = TYPE_AP_BUS,
> + .parent = TYPE_BUS,
> + .instance_size = sizeof(APBus),
> + .class_init = vfio_ap_bus_class_init,
> +};
> +
[..]
> +static void ap_register(void)
> +{
> + type_register_static(&ap_bridge_info);
> + type_register_static(&vfio_ap_bus_info);
> +}
> +
[..]
- [Qemu-devel] [PATCH v9 6/6] s390: doc: detailed specifications for AP virtualization, (continued)
- [Qemu-devel] [PATCH v9 6/6] s390: doc: detailed specifications for AP virtualization, Tony Krowiak, 2018/09/26
- [Qemu-devel] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, Tony Krowiak, 2018/09/26
- Re: [Qemu-devel] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, David Hildenbrand, 2018/09/27
- Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, Thomas Huth, 2018/09/27
- Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, Halil Pasic, 2018/09/28
- Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, Cornelia Huck, 2018/09/28
- Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, Thomas Huth, 2018/09/28
- Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model, Tony Krowiak, 2018/09/28
- Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model,
Halil Pasic <=
[Qemu-devel] [PATCH v9 5/6] s390x/vfio: ap: Introduce VFIO AP device, Tony Krowiak, 2018/09/26
[Qemu-devel] [PATCH v9 3/6] s390x/kvm: enable AP instruction interpretation for guest, Tony Krowiak, 2018/09/26
[Qemu-devel] [PATCH v9 2/6] s390x/cpumodel: Set up CPU model for AP device support, Tony Krowiak, 2018/09/26